Push Server Metrics to capture

[David Martin]

There are 2 metrics already captured in the push server metrics endpoint.

More info here

https://github.com/aerogear/aerogear-unifiedpush-server/pull/949

Related trello with more info on the story [1]

I'm interested in any suggestions on what else could/should be included in the metrics endpoint.

CPU/RAM will already be captured by heapster in openshift

Any thoughts on using the same approach as keycloak & including default exports

https://github.com/prometheus/client_java#included-collectors

https://github.com/aerogear/keycloak-metrics-spi/blob/master/src/main/java/org/jboss/aerogear/keycloak/metrics/PrometheusExporter.java#L55

?

Is there anything else specific to administering a push server that would be useful?

[1] https://trello.com/c/tPin7vee/22-as-a-developer-i-want-to-be-able-to-expose-metrics-data-about-push-in-prometheus-format-from-an-endpoint-of-this-service

--

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev

[Matthias Wessendorf-2]

+1 on DefaultExports usage

On Mon, Jan 22, 2018 at 11:43 AM, David Martin <[hidden email]> wrote:

There are 2 metrics already captured in the push server metrics endpoint.

More info here

https://github.com/aerogear/aerogear-unifiedpush-server/pull/949

Related trello with more info on the story [1]

I'm interested in any suggestions on what else could/should be included in the metrics endpoint.

CPU/RAM will already be captured by heapster in openshift

Any thoughts on using the same approach as keycloak & including default exports

https://github.com/prometheus/client_java#included-collectors

https://github.com/aerogear/keycloak-metrics-spi/blob/master/src/main/java/org/jboss/aerogear/keycloak/metrics/PrometheusExporter.java#L55

?

Is there anything else specific to administering a push server that would be useful?

[1] https://trello.com/c/tPin7vee/22-as-a-developer-i-want-to-be-able-to-expose-metrics-data-about-push-in-prometheus-format-from-an-endpoint-of-this-service

--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev

--

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev

[Peter Braun]

One of the captured metrics is ‚push_requests_total‘. It would be nice to add a label here to group by platform, e.g. ‚push_requests_total{platform=„android“} = 5.0‘

About the default metrics. They are free and i think we should include them just to have the same behavior in our metrics endpoints as much as possible.

Am 22.01.2018 um 11:43 schrieb David Martin <[hidden email]>:

There are 2 metrics already captured in the push server metrics endpoint.

More info here

https://github.com/aerogear/aerogear-unifiedpush-server/pull/949

Related trello with more info on the story [1]

I'm interested in any suggestions on what else could/should be included in the metrics endpoint.

CPU/RAM will already be captured by heapster in openshift

Any thoughts on using the same approach as keycloak & including default exports

https://github.com/prometheus/client_java#included-collectors

https://github.com/aerogear/keycloak-metrics-spi/blob/master/src/main/java/org/jboss/aerogear/keycloak/metrics/PrometheusExporter.java#L55

?

Is there anything else specific to administering a push server that would be useful?

[1] https://trello.com/c/tPin7vee/22-as-a-developer-i-want-to-be-able-to-expose-metrics-data-about-push-in-prometheus-format-from-an-endpoint-of-this-service

--

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev

[Matthias Wessendorf]

On Mon, Jan 22, 2018 at 12:23 PM, Peter Braun <[hidden email]> wrote:

One of the captured metrics is ‚push_requests_total‘. It would be nice to add a label here to group by platform, e.g. ‚push_requests_total{platform=„android“} = 5.0‘

+1  we could do that, instead (or in addition)

 

About the default metrics. They are free and i think we should include them just to have the same behavior in our metrics endpoints as much as possible.

+1 

 

Am 22.01.2018 um 11:43 schrieb David Martin <[hidden email]>:

There are 2 metrics already captured in the push server metrics endpoint.

More info here

https://github.com/aerogear/aerogear-unifiedpush-server/pull/949

Related trello with more info on the story [1]

I'm interested in any suggestions on what else could/should be included in the metrics endpoint.

CPU/RAM will already be captured by heapster in openshift

Any thoughts on using the same approach as keycloak & including default exports

https://github.com/prometheus/client_java#included-collectors

https://github.com/aerogear/keycloak-metrics-spi/blob/master/src/main/java/org/jboss/aerogear/keycloak/metrics/PrometheusExporter.java#L55

?

Is there anything else specific to administering a push server that would be useful?

[1] https://trello.com/c/tPin7vee/22-as-a-developer-i-want-to-be-able-to-expose-metrics-data-about-push-in-prometheus-format-from-an-endpoint-of-this-service

--

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev

--

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev

[Massimiliano Ziccardi]

I think it would be a good idea to have pinpoint as well.

Il 22 Gen 2018 12:29 PM, "Matthias Wessendorf" <[hidden email]> ha scritto:

+1 on DefaultExports usage

On Mon, Jan 22, 2018 at 11:43 AM, David Martin <[hidden email]> wrote:

There are 2 metrics already captured in the push server metrics endpoint.

More info here

https://github.com/aerogear/aerogear-unifiedpush-server/pull/949

Related trello with more info on the story [1]

I'm interested in any suggestions on what else could/should be included in the metrics endpoint.

CPU/RAM will already be captured by heapster in openshift

Any thoughts on using the same approach as keycloak & including default exports

https://github.com/prometheus/client_java#included-collectors

https://github.com/aerogear/keycloak-metrics-spi/blob/master/src/main/java/org/jboss/aerogear/keycloak/metrics/PrometheusExporter.java#L55

?

Is there anything else specific to administering a push server that would be useful?

[1] https://trello.com/c/tPin7vee/22-as-a-developer-i-want-to-be-able-to-expose-metrics-data-about-push-in-prometheus-format-from-an-endpoint-of-this-service

--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev

--

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev

[Matthias Wessendorf]

I think that's a completely different beast, since more for profiling - while still useful, to bring in to learn more 

check the cards in the trello there is one that might fit for pinpoint

On Mon, Jan 22, 2018 at 7:57 PM, Massimiliano Ziccardi <[hidden email]> wrote:

I think it would be a good idea to have pinpoint as well.

Il 22 Gen 2018 12:29 PM, "Matthias Wessendorf" <[hidden email]> ha scritto:

+1 on DefaultExports usage

On Mon, Jan 22, 2018 at 11:43 AM, David Martin <[hidden email]> wrote:

There are 2 metrics already captured in the push server metrics endpoint.

More info here

https://github.com/aerogear/aerogear-unifiedpush-server/pull/949

Related trello with more info on the story [1]

I'm interested in any suggestions on what else could/should be included in the metrics endpoint.

CPU/RAM will already be captured by heapster in openshift

Any thoughts on using the same approach as keycloak & including default exports

https://github.com/prometheus/client_java#included-collectors

https://github.com/aerogear/keycloak-metrics-spi/blob/master/src/main/java/org/jboss/aerogear/keycloak/metrics/PrometheusExporter.java#L55

?

Is there anything else specific to administering a push server that would be useful?

[1] https://trello.com/c/tPin7vee/22-as-a-developer-i-want-to-be-able-to-expose-metrics-data-about-push-in-prometheus-format-from-an-endpoint-of-this-service

--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev

--

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev

--

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev