When to merge a proposal

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

When to merge a proposal

Craig Brookes
I think we should use a common strategy in the Open Source world, that in general you need at least two LGTM thumbs up from bona fide reviewers before being allowed to merge.

Thoughts? 

--
Craig Brookes
RHMAP 
@maleck13 Github

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev
Reply | Threaded
Open this post in threaded view
|

Re: When to merge a proposal

John Frizelle
LGTM :-)

--
John Frizelle
Chief Architect, Red Hat Mobile
Consulting Engineer

mobile: <a href="tel://+353872901644" target="_blank">+353 87 290 1644
twitter: @johnfriz
skype: john_frizelle




On 15 December 2017 at 10:05, Craig Brookes <[hidden email]> wrote:
I think we should use a common strategy in the Open Source world, that in general you need at least two LGTM thumbs up from bona fide reviewers before being allowed to merge.

Thoughts? 

--
Craig Brookes
RHMAP 
@maleck13 Github

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev



_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev
Reply | Threaded
Open this post in threaded view
|

Re: When to merge a proposal

David Martin
+1



On 15 December 2017 at 10:06, John Frizelle <[hidden email]> wrote:
LGTM :-)

--
John Frizelle
Chief Architect, Red Hat Mobile
Consulting Engineer

mobile: <a href="tel://+353872901644" target="_blank">+353 87 290 1644
twitter: @johnfriz
skype: john_frizelle




On 15 December 2017 at 10:05, Craig Brookes <[hidden email]> wrote:
I think we should use a common strategy in the Open Source world, that in general you need at least two LGTM thumbs up from bona fide reviewers before being allowed to merge.

Thoughts? 

--
Craig Brookes
RHMAP 
@maleck13 Github

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev



_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev




--
David Martin
Red Hat Mobile
Twitter: @irldavem
IRC: @irldavem (feedhenry, mobile-internal)

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] When to merge a proposal

Jose Miguel Gallas Olmedo
At least 2 sounds about right

JOSE MIGUEL GALLAS OLMEDO

ASSOCIATE QE, mobile

Red Hat 

<span href="tel:+34618488633">M: +34618488633    


On 15 December 2017 at 11:14, David Martin <[hidden email]> wrote:
+1



On 15 December 2017 at 10:06, John Frizelle <[hidden email]> wrote:
LGTM :-)

--
John Frizelle
Chief Architect, Red Hat Mobile
Consulting Engineer

mobile: <a href="tel://+353872901644" target="_blank">+353 87 290 1644
twitter: @johnfriz
skype: john_frizelle




On 15 December 2017 at 10:05, Craig Brookes <[hidden email]> wrote:
I think we should use a common strategy in the Open Source world, that in general you need at least two LGTM thumbs up from bona fide reviewers before being allowed to merge.

Thoughts? 

--
Craig Brookes
RHMAP 
@maleck13 Github

_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev



_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev




--
David Martin
Red Hat Mobile
Twitter: @irldavem
IRC: @irldavem (feedhenry, mobile-internal)

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
feedhenry-dev mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/feedhenry-dev